Fix PropTypes in addons/knobs NumberType #4669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If knob.value is null or undefined, it gets converted to a string, but the PropTypes did not reflect this.
tarikhamilton
requested review from
alexandrebodin,
alterx,
Hypnosphi,
leonrodenburg and
theinterned
as code owners
Hypnosphi
approved these changes
Nov 4, 2018
Hypnosphi
added
bug
addon: knobs
patch:yes
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Nov 6, 2018
Fix PropTypes in addons/knobs NumberType
This was referenced Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If knob.value is null or undefined, it gets converted to a string, but the PropTypes did not reflect this.
Issue:
What I did
Updated
NumberType.propTypesin addon/knobs to allow strings so errors aren't thrown when clearing the number input (necessary if you'd like to pass null to a prop, see: 85e4955).How to test
Erase the number in the input field and you should get a PropTypes error.
Is this testable with Jest or Chromatic screenshots? No.
Does this need a new example in the kitchen sink apps? No.
Does this need an update to the documentation? No.