[ember] update ember ergonomics to not require any manual setup

[gabrielcsapo]

Issue: The previously submitted PR did not accommodate for dist not being around, changes were made in the ember-cli-storybook plugin to ensure it used the right build time hook to ensure dist was available.

What I did

Removes hacky solutions for setting up ember environment, now supports ember's live reload out of the box.

[codecov]

Codecov Report

Merging #4594 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4594   +/-   ##
=======================================
  Coverage   35.59%   35.59%           
=======================================
  Files         557      557           
  Lines        6732     6732           
  Branches      884      884           
=======================================
  Hits         2396     2396           
  Misses       3876     3876           
  Partials      460      460

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de2180...2233ff0. Read the comment docs.

[shilman]

@gabrielcsapo smoke tests are still failing. mind looking into it? also there is a conflict in yarn.lock

[gabrielcsapo]

@igor-dv @ndelangen would you be able to take a look at this?

[shilman]

@gabrielcsapo What's storybook:dev supposed to do? It doesn't seem to work:

$$ yarn storybook:dev
yarn run v1.10.1
$ yarn serve & start-storybook -p 9009 -s dist, public
error Command "serve" not found.

[gabrielcsapo]

@shilman it was supposed to be ember serve, I made it yarn dev instead. The live reload has a race condition that happens because you need ember serve to finish serving before starting the storybook process, working on an enhancement to ember-cli-storybook that lets you do this running a command like ember storybook serve

[shilman]

This can be &&?

[shilman]

I don't think dist, public works (tested briefly on my machine).

Also I don't think it's necessary -- looks like ember copies everything from public into dist when it builds?

[gabrielcsapo]

I don't know if that is the cases, I know I needed to copy the files for build-storybook, these are needed

[shilman]

When I added a new file logo1.png into public it automatically gets copied into dist when I ember build.

When I yarn storybook and try to access it at the following URL, it succeeds:

http://localhost:9009/logo1.png

When I remove the file from dist and try to access it at the following URL, it 404s:

http://localhost:9009/logo1.png

Therefore, I believe:

1. The syntax "dist, public" doesn't work (maybe no comma is needed?), or possibly Storybook's ability to serve from multiple directories doesn't work.
2. We don't even need to be serving from public because ember build does the copying even when I don't use the file anywhere.

[gabrielcsapo]

makes sense, tested this also and it works.

[gabrielcsapo]

@shilman I think I resolved your feedback

[shilman]

LGTM!