[onDeviceUI] Add ability to render addons in React Native #4381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isUIOpen - whether to initially show top bar - default true. isStoryMenuOpen - should show story menu open by default - default false.
We cannot use modal since addons expect to be rendered all the time. So now we display the wrapper as position absolute and make it 0 0 size when it is not visible.
…s to story change events once instead of twice.
Updated readme, Renamed handlers.
[onDeviceUI] Add ability to render addons in React Native
Fixed where width is taken from.
Gongreg
requested review from
danielduan,
rmevans9 and
tmeasday
as code owners
Generated by 🚫 dangerJS |
This was referenced Nov 1, 2018
This was referenced Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to change base branch before on merging #3903 . This PR is to merge that branch into the master.