[onDeviceUI] Adding on device addons. #4327
Merged
+1,636
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
approved these changes
Oct 9, 2018
| @@ -0,0 +1,33 @@ | |||
| { | |||
| "name": "@storybook/addon-ondevice-backgrounds", | |||
| "version": "4.0.0-alpha.20", | |||
| "prepare": "node ../../scripts/prepare.js" | ||
| }, | ||
| "dependencies": { | ||
| "@storybook/addons": "4.0.0-alpha.20", |
addons/ondevice-knobs/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@storybook/addons": "4.0.0-alpha.20", | ||
| "@storybook/addon-knobs": "4.0.0-alpha.20", |
There was a problem hiding this comment.
A person who uses ondevice-knobs will be still importing addon-knobs inside their app. So if he doesn't install it directly we still want him to have it in his node_modules. @igor-dv.
There was a problem hiding this comment.
Yes, but users will need to install it explicitly. In that case, you probably want it to be a peer
addons/ondevice-knobs/package.json
Outdated
| "prop-types": "^15.6.2", | ||
| "react-native-color-picker": "^0.4.0", | ||
| "react-native-modal-datetime-picker": "^5.1.0", | ||
| "react-native-modal-selector": "0.0.27", |
There was a problem hiding this comment.
should this be stuck to the exact version?
|
Nothing seems to be blocking this PR too @ndelangen, @igor-dv. |
|
Let's merge if after the #3903 is ready? We won't use addons without the support for addons, right? |
|
Sure. |
|
merge when ready |
ndelangen
approved these changes
Oct 12, 2018
This was referenced Nov 1, 2018
This was referenced Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #3903.
This adds 3 on device addons: Notes, Knobs, Backgrounds.
They are definitely not the cleanest and up to date addons.
Looking forward @ndelangen suggested that we have to think of the way to display addons as webviews in the app. But for now these are good enough to display that we can have addons in the app.