Storybook for HTML snippets #3475
Conversation
Hypnosphi
requested review from
ndelangen,
shilman and
stijnkoopal
as code owners
| e.preventDefault(); | ||
| linkTo(kind, story)(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
We could incorporate something like this into links addon
There was a problem hiding this comment.
I can't see how it will work with a real-world example, because probably your components won't be coupled to the "story"/"kind"
There was a problem hiding this comment.
We can use some namespace, like data-sb-story
There was a problem hiding this comment.
The idea is, if you want a link to other story, you just add corresponding data-attribute to the element that you want to be the link
| .add('button', () => { | ||
| const button = document.createElement('button'); | ||
| button.innerText = 'Hello Button'; | ||
| button.addEventListener('click', action('Click')); |
There was a problem hiding this comment.
I have some thoughts on adding a decorator with backbone-style event listeners hash:
.addDecorator(withActions({
dblclick : 'Double click',
'click .icon.doc': 'Doc icon click',
'contextmenu .icon.doc': 'Doc icon right click'
}))
# Conflicts: # .teamcity/OpenSourceProjects_Storybook/buildTypes/OpenSourceProjects_Storybook_Examples.kt # .teamcity/OpenSourceProjects_Storybook/buildTypes/StotybookApp.kt
This reverts commit 9243827
| e.preventDefault(); | ||
| linkTo(kind, story)(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I can't see how it will work with a real-world example, because probably your components won't be coupled to the "story"/"kind"
I'd appreciate any. I'll create a slack channel to coordinate |
|
Ok I think it's ready for final review |
| .add('button', () => { | ||
| const button = document.createElement('button'); | ||
| button.innerText = 'Hello Button'; | ||
| // eslint-disable-next-line no-console |
There was a problem hiding this comment.
Should we remove eslint stuff from docs?
Issue: #3157
Live example
Todo: