New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap fs.statSync and fs.lstatSync #783
Conversation
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
=========================================
+ Coverage 95.39% 95.4% +<.01%
=========================================
Files 33 33
Lines 1239 1241 +2
=========================================
+ Hits 1182 1184 +2
Misses 57 57
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any noticeable performance hit by adding an extra function call?
It's doubtful. I think V8 will just inline the functions anyway. |
Fixes #745
Adds two new methods to
src/common.js
,common.statFollowLinks
andcommon.statNoFollowLinks
, which wrapfs.statSync
andfs.lstatSync
, respectively. This change is meant to improve readability and clarify intent.