New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set AVA options #780
Conversation
This sets 2 AVA options: * `serial`: same behavior as the CLI flag, which this replaces * `powerAssert`: if an assert fails, it will inspect all objects involved in the failed assert. This causes readability issues if `t.falsy(shell.error())` breaks, since it inspects all of `shell` (which is way too large). AVA options are a little easier to manage than CLI options (we only update one place instead of 2 in `package.json`).
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 33 33
Lines 1237 1237
=======================================
Hits 1180 1180
Misses 57 57 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd rather have verbose test output (with powerAssert
) than too little information to debug with.
The output is still improved over previous AVA output (it's pretty good). It's just catastrophically verbose with the |
This sets 2 AVA options:
serial
: same behavior as the CLI flag, which this replacespowerAssert
: if an assert fails, it will inspect all objects involved inthe failed assert. This causes readability issues if
t.falsy(shell.error())
breaks, since it inspects all of
shell
(which is way too large).AVA options are a little easier to manage than CLI options (we only update one
place instead of 2 in
package.json
).