New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate common.getUserHome, advise using os.homedir instead #725
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #725 +/- ##
==========================================
+ Coverage 96.63% 96.71% +0.07%
==========================================
Files 33 33
Lines 1160 1156 -4
==========================================
- Hits 1121 1118 -3
+ Misses 39 38 -1
Continue to review full report at Codecov.
|
src/common.js
Outdated
@@ -157,6 +158,8 @@ function ShellString(stdout, stderr, code) { | |||
|
|||
exports.ShellString = ShellString; | |||
|
|||
// DEPRECATED: Use os.homedir instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't deprecate internal functions, just remove them. We only explicitly export the functions listed here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up!
* Deprecate common.getUserHome, advise using os.homedir instead * Remove common.getUserHome
* Deprecate common.getUserHome, advise using os.homedir instead * Remove common.getUserHome
Deprecates
common.getUserHome
and provides a warning about the deprecation. Also replaces all of the internal uses ofcommon.getUserHome
withos.homedir
.Fixes #683