Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] onTouchStart property required #78

Closed
Mamoru1234 opened this issue Apr 24, 2018 · 4 comments
Closed

[Bug] onTouchStart property required #78

Mamoru1234 opened this issue Apr 24, 2018 · 4 comments
Assignees
@scniro
Labels
bug

Comments

@Mamoru1234
Copy link
Contributor

Actual behavior:
According to this line onTouchStart is required property.
Expected behavior:
onTouchStart should be optional.
@scniro
Copy link
Owner

scniro commented Apr 24, 2018

@Mamoru1234 dang, good catch. Yep, onTouchStart needs to be onTouchStart? I'll get a fix in this evening please just no-op it for now if you can get by

@scniro scniro added the bug label Apr 24, 2018
@scniro scniro self-assigned this Apr 24, 2018
Mamoru1234 added a commit to Mamoru1234/react-codemirror2 that referenced this issue Apr 24, 2018
@Mamoru1234
Made onTouchStart optional scniro#78
8399c80
@Mamoru1234
Copy link
Contributor Author

Mamoru1234 commented Apr 24, 2018 •
edited

@scniro thanks for attention. It's critically simple to fix exactly this case, and I have created PR with fix.
But general problem why npm run test passed when code in tests are not valid example?

scniro added a commit that referenced this issue Apr 24, 2018
@scniro
Merge pull request #79 from Mamoru1234/master
845a333 
Made onTouchStart optional #78
@scniro
Copy link
Owner

scniro commented Apr 24, 2018

@Mamoru1234 I don't enforce any of the type checking for the tests. I probably should after seeing this (lol). PR merged, will bump a publish in a few moment

scniro added a commit that referenced this issue Apr 24, 2018
@scniro
#78
835018c
@scniro
Copy link
Owner

scniro commented Apr 24, 2018

@Mamoru1234 fixed with the 5.0.1 release

@scniro scniro closed this as completed Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scniro scniro

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mamoru1234 @scniro