Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.assign doesn't work by default in Internet Explorer #76

Closed
anandsainath opened this issue Apr 17, 2018 · 3 comments
Closed

Object.assign doesn't work by default in Internet Explorer #76

anandsainath opened this issue Apr 17, 2018 · 3 comments

Comments

@anandsainath
Copy link
Contributor

We use Object.assign in the following line -

let userDefinedOptions = Object.assign({}, cm.defaults, this.editor.options, props.options || {});

Unfortunately, Internet Explorer doesn't have a definition for the same. And its very difficult to override object.assign from an external module :(

Can we depend on an external library (like core-js) to get the definition for assign and use that instead?

@scniro
Copy link
Owner

scniro commented Apr 18, 2018

@anandsainath Are you using webpack/babel? I suppose I can add a polyfill, but it feels so... gross. I'll keep you posted with if I add anything but I definitely think you can handle this through a bundler.

scniro added a commit that referenced this issue Apr 22, 2018
@scniro
Copy link
Owner

scniro commented Apr 22, 2018

@anandsainath fixed with the 4.3.0 release

@scniro scniro closed this as completed Apr 22, 2018
@anandsainath
Copy link
Contributor Author

@scniro Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants