-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more files to npm distribution #2552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't appear to have any negative consequences. Does it solve a particular issue?
Mainly that we have been building an ESM browser build for quite some time but forgot to publish it. And I guess the source maps that had been created but were not delivered do not hurt as well. |
It seems like the source maps will increase the package download size by around 4MB, which may not be ideal I think? Also I'm not sure the debugging experience is necessarily improved by having the source maps included? It's pretty standard for built libraries to not bundle their source maps. If we turned them off entirely that would even give us faster builds? |
Good point regarding performance but I think the main time-sink is typescript and minification of the browser bundle at the moment. And I guess finding error locations in tests will be more difficult? I will play around with this a little. I did not check the size of the source maps. Yes, more than doubling the size of our generated package is probably not ideal. Will change this to only add the browser build. |
…enerate sourcemaps relevant for tests
Ok
|
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
At the moment, both the browser esm build as well as the generated sourcemaps are not published to npm. This will change the configuration to include those files as well.