New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(javascript): inline property decorator should stay inline (part 2) #5423
fix(javascript): inline property decorator should stay inline (part 2) #5423
Conversation
docs/rationale.md
Outdated
@@ -99,24 +99,6 @@ class HeroButtonComponent { | |||
} | |||
``` | |||
|
|||
There's one exception: classes. We don't think it ever makes sense to inline the decorators for them, so they are always moved to their own line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--> #5360 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the property changes, but the classes I don't think we should change 🤷♂️
It was one person who "complained" and also noted the mobx docs have example of both kinds, but I'm not willing do die on any particular hill these days, so you all are free to decide which is best.
OK, let's bisect them from this PR and see how people think about it. |
Fixes cases mentioned in #5360 (comment)
docs/
directory)✨Try the playground for this PR✨