This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Do not redirect the env command to set, for windows bash shell
#19418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything I can do to help this PR? |
gucong3000
changed the title
env command to set, in Cygwin (Windows)
andelmad
approved these changes
Mar 11, 2018
|
Hi @gucong3000, thank for your patience! While we don't officially support cygwin, I'm ok with taking patches for it that we can be confident won't cause other issues. In this case, I would suggest you add your Cygwin detection to |
iarna
suggested changes
Apr 12, 2018
lib/run-script.js
Outdated
| @@ -138,7 +138,7 @@ function run (pkg, wd, cmd, args, cb) { | |||
| if (cmd === 'test') { | |||
| pkg.scripts.test = 'echo \'Error: no test specified\'' | |||
| } else if (cmd === 'env') { | |||
| if (process.platform === 'win32') { | |||
| if (process.platform === 'win32' && !/^(msys|cygwin)$/.test(process.env.OSTYPE)) { | |||
There was a problem hiding this comment.
Use lib/utils/is-windows-bash.js and update that to include cygwin.
gucong3000
changed the title
env command to set, in Cygwin (Windows)env command to set, for windows bash shell
|
@iarna Thanks for your patience. Modified. |
iarna
reviewed
Jul 10, 2018
| @@ -1,3 +1,4 @@ | |||
| 'use strict' | |||
| var isWindows = require('./is-windows.js') | |||
| module.exports = isWindows && /^MINGW(32|64)$/.test(process.env.MSYSTEM) | |||
| var env = process.env | |||
| module.exports = isWindows && (env.MSYSTEM ? /^MINGW(32|64)$/.test(env.MSYSTEM) : env.TERM === "cygwin") | |||
There was a problem hiding this comment.
The env.MSYSTEM guard here is unnecessary… but ah, I'll take and make a small change. =)
iarna
pushed a commit
to npm/cli
that referenced
this pull request
Jul 10, 2018
Credit: @gucong3000 PR-URL: npm/npm#19418 Reviewed-By: @iarna
|
Thanks! This is landing as 4c32413! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envonly for window cmd shell%ProgramFiles%\Git\usr\bin\bash.exeforlib/utils/is-windows-bash.js#19419