This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
lib: Add sign-git-commit config #12697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribou
force-pushed
the
12696-git-sign-commit
branch
from
a151a0d
to
33191e6
Compare
tribou
force-pushed
the
12696-git-sign-commit
branch
from
33191e6
to
74f9011
Compare
zkat
approved these changes
Mar 7, 2018
|
@zkat Just a heads up! I originally wrote this PR against I'm afraid it might need to be rewritten 😢 |
|
@tribou I think you'll find the conflict to be very small! It would be great if you just resolved the conflict and pushed out a new, rebased version -- or I can do it myself when it's time to merge (although that'd be more work for me lolsob). Your patch is straightforward enough :) |
|
Ah, I didn't realize that! I'll try to look into it soon |
|
I'm doing my merges today, and it looks like this isn't ready yet, so I'm pushing it out until next time we do a PR sweep. |
zkat
force-pushed
the
release-next
branch
5 times, most recently
from
83a5d44
to
a571f80
Compare
iarna
force-pushed
the
release-next
branch
3 times, most recently
from
bcc4670
to
4a65b3b
Compare
iarna
force-pushed
the
release-next
branch
5 times, most recently
from
2e76172
to
fe31e66
Compare
iarna
force-pushed
the
release-next
branch
2 times, most recently
from
63c9452
to
1b021d0
Compare
iarna
force-pushed
the
release-next
branch
2 times, most recently
from
691cb35
to
bf3cfa7
Compare
iarna
force-pushed
the
release-next
branch
6 times, most recently
from
3f32220
to
f29b7a6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
sign-git-commitconfig referenced in #12696