Skip to content

Commit

Permalink
config: fix no-proxy to noproxy (#46)
Browse files Browse the repository at this point in the history
Fixes: https://npm.community/t/1327
PR-URL: #46
Credit: @sneakyfish5
Reviewed-By: @zkat
  • Loading branch information
jmannanc authored and zkat committed Aug 20, 2018
1 parent 4bd40f5 commit 0e576f0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion doc/misc/npm-config.md
Expand Up @@ -692,7 +692,7 @@ impact how lifecycle scripts are called.

The node version to use when checking a package's `engines` map.

### no-proxy
### noproxy

* Default: null
* Type: String or Array
Expand Down
4 changes: 2 additions & 2 deletions lib/config/defaults.js
Expand Up @@ -196,7 +196,7 @@ Object.defineProperty(exports, 'defaults', {get: function () {
'progress': !process.env.TRAVIS && !process.env.CI,
proxy: null,
'https-proxy': null,
'no-proxy': null,
'noproxy': null,
'user-agent': 'npm/{npm-version} ' +
'node/{node-version} ' +
'{platform} ' +
Expand Down Expand Up @@ -318,7 +318,7 @@ exports.types = {
'metrics-registry': [null, String],
'node-options': [null, String],
'node-version': [null, semver],
'no-proxy': [null, String, Array],
'noproxy': [null, String, Array],
offline: Boolean,
'onload-script': [null, String],
only: [null, 'dev', 'development', 'prod', 'production'],
Expand Down
2 changes: 1 addition & 1 deletion lib/config/pacote.js
Expand Up @@ -38,7 +38,7 @@ function pacoteOpts (moreOpts) {
preferOnline: npm.config.get('prefer-online') || npm.config.get('cache-max') <= 0,
projectScope: npm.projectScope,
proxy: npm.config.get('https-proxy') || npm.config.get('proxy'),
noProxy: npm.config.get('no-proxy'),
noProxy: npm.config.get('noproxy'),
refer: npm.registry.refer,
registry: npm.config.get('registry'),
retry: {
Expand Down

0 comments on commit 0e576f0

Please sign in to comment.