doc: improve urlObject.auth text #22324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify format explanation for urlObject.auth.
The "at sign" is properly the "commercial at" but let's just avoid the whole naming issue by putting the symbol right in the sentence.
nodejs-github-bot
added
doc
vsemozhetbyt
approved these changes
Aug 14, 2018
vsemozhetbyt
added
the
author ready
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
bengl
approved these changes
Aug 14, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 14, 2018
PR-URL: nodejs#22324 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 14, 2018
Simplify format explanation for urlObject.auth. PR-URL: nodejs#22324 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 14, 2018
The "at sign" is properly the "commercial at" but let's just avoid the whole naming issue by putting the symbol right in the sentence. PR-URL: nodejs#22324 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
|
Landed in 85f7ae4...b002f6e |
rvagg
pushed a commit
that referenced
this pull request
Aug 15, 2018
PR-URL: #22324 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
rvagg
pushed a commit
that referenced
this pull request
Aug 15, 2018
Simplify format explanation for urlObject.auth. PR-URL: #22324 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
rvagg
pushed a commit
that referenced
this pull request
Aug 15, 2018
The "at sign" is properly the "commercial at" but let's just avoid the whole naming issue by putting the symbol right in the sentence. PR-URL: #22324 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nodejs/documentation @nodejs/url
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes