lib: Remove unused param for filterInternalStackFrames
#22267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually we don't refer the `error` directly in `filterInternalStackFrames`, so just remove it anyway.
cjihrig
approved these changes
Aug 11, 2018
maclover7
approved these changes
Aug 12, 2018
|
Resumed build: https://ci.nodejs.org/job/node-test-pull-request/16376/ |
trivikr
approved these changes
Aug 12, 2018
maclover7
added
the
author ready
BridgeAR
approved these changes
Aug 13, 2018
jasnell
approved these changes
Aug 13, 2018
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16438/ (edit: ✔️) |
|
Landed in 8018146 (made a slight adjustment to commit message so it would pass core-validate-commit) |
maclover7
pushed a commit
that referenced
this pull request
Aug 14, 2018
Actually we don't refer the `error` directly in `filterInternalStackFrames`, so just remove it anyway. PR-URL: #22267 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
ghost
deleted the
|
Thanks! |
rvagg
pushed a commit
that referenced
this pull request
Aug 15, 2018
Actually we don't refer the `error` directly in `filterInternalStackFrames`, so just remove it anyway. PR-URL: #22267 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually we don't refer the
errordirectly infilterInternalStackFrames, so just remove it anyway.make -j4 test(UNIX), orvcbuild test(Windows) passes