Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: explicitly disallow nested push streams #22245

Closed
wants to merge 1 commit into from
Closed

http2: explicitly disallow nested push streams #22245

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 10, 2018

Fixes: #19095

/cc @nodejs/http2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/500/pipeline

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x errors Issues and PRs related to JavaScript errors originated in Node.js core. http2 Issues or PRs related to the http2 subsystem. labels Aug 10, 2018
@jasnell
Copy link
Member Author

jasnell commented Aug 10, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16347/

mcollina
mcollina approved these changes Aug 10, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 11, 2018
jasnell added a commit that referenced this pull request Aug 13, 2018
@jasnell
http2: explicitly disallow nested push streams
78584b6 
Fixes: #19095

PR-URL: #22245
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Aug 13, 2018

Landed in 78584b6

@jasnell jasnell closed this Aug 13, 2018
rvagg pushed a commit that referenced this pull request Aug 15, 2018
@jasnell @rvagg
http2: explicitly disallow nested push streams
a562729 
Fixes: #19095

PR-URL: #22245
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@rvagg rvagg mentioned this pull request Aug 15, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
@jasnell @kjin
http2: explicitly disallow nested push streams
68e5ef9 
Fixes: nodejs#19095

PR-URL: nodejs#22245
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@jasnell @kjin
http2: explicitly disallow nested push streams
f1e310e 
Fixes: nodejs#19095

PR-URL: nodejs#22245
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@jasnell @BethGriggs
http2: explicitly disallow nested push streams
cc561cc 
Fixes: #19095

Backport-PR-URL: #22850
PR-URL: #22245
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@trivikr trivikr trivikr approved these changes

@addaleax addaleax Awaiting requested review from addaleax

@apapirovski apapirovski Awaiting requested review from apapirovski

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jasnell @nodejs-github-bot @mcollina @trivikr