test: remove second arg from assert.ifError() #22190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test/parallel/test-fs-readfile.js` has a call to `assert.ifError()` that receives two arguments. There is no second argument used in `assert.ifError()`. This PR removes this argument.
gdams
approved these changes
Aug 8, 2018
richardlau
approved these changes
Aug 8, 2018
cjihrig
approved these changes
Aug 8, 2018
maclover7
approved these changes
Aug 8, 2018
maclover7
added
the
author ready
BridgeAR
approved these changes
Aug 8, 2018
trivikr
approved these changes
Aug 8, 2018
lpinca
approved these changes
Aug 8, 2018
Trott
approved these changes
Aug 9, 2018
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16309/ |
jasnell
approved these changes
Aug 9, 2018
jasnell
pushed a commit
that referenced
this pull request
Aug 10, 2018
`test/parallel/test-fs-readfile.js` has a call to `assert.ifError()` that receives two arguments. There is no second argument used in `assert.ifError()`. This PR removes this argument. PR-URL: #22190 Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in dcfd323! |
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Aug 11, 2018
`test/parallel/test-fs-readfile.js` has a call to `assert.ifError()` that receives two arguments. There is no second argument used in `assert.ifError()`. This PR removes this argument. PR-URL: #22190 Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/parallel/test-fs-readfile.jshas a call toassert.ifError()that receives two arguments.There is no second argument used in
assert.ifError(). This PR removes this argument.This fix was recommended by @Trott via NodeTodo.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes