test: handle errors correctly in test-gc-http-client-timeout.js #22185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apapirovski
reviewed
Aug 8, 2018
| @@ -39,7 +39,9 @@ function getall() { | |||
| pathname: '/', | |||
| port: server.address().port | |||
| }, cb); | |||
| req.on('error', cb); | |||
| req.on('error', (err) => { | |||
There was a problem hiding this comment.
Not having this listener would result in the same outcome, I believe.
lpinca
approved these changes
Aug 8, 2018
Trott
approved these changes
Aug 9, 2018
Trott
added
the
author ready
|
Run again on linuxone: https://ci.nodejs.org/job/node-test-commit-linuxone/3775/ |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 10, 2018
In test-gc-http-client-timeout.js, res.resume is not a function if error occurs. Remove the error handler. PR-URL: nodejs#22185 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 2e37d0f |
targos
pushed a commit
that referenced
this pull request
Aug 11, 2018
In test-gc-http-client-timeout.js, res.resume is not a function if error occurs. Remove the error handler. PR-URL: #22185 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this,
test-gc-http-client-timeout.jslogsres.resume is not a functionwhen errors are emitted.This test sometimes fails on my OSX because
getaddrinfomay returnENOTFOUND. (The actual uv error code isUV_EAI_NONAME.)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes