Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mark DEP0004 and DEP0042 as End-of-Life #22033

Closed
wants to merge 1 commit into from
Closed

doc: mark DEP0004 and DEP0042 as End-of-Life #22033

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

CryptoStream was removed via 9301b8a (cc @addaleax)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@maclover7 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/383/pipeline

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Jul 30, 2018
addaleax
addaleax approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I guess they should have been marked as runtime-deprecated before?

@maclover7
Copy link
Contributor Author

Landed in 13d7086, thank you for the reviews!

@maclover7 maclover7 closed this Aug 1, 2018
@maclover7 maclover7 deleted the jm-cryptostream branch August 1, 2018 19:53
maclover7 added a commit that referenced this pull request Aug 1, 2018
@maclover7
doc: mark DEP0004 and DEP0042 as End-of-Life
13d7086 
`CryptoStream` was removed via 9301b8a.

PR-URL: #22033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos
Copy link
Member

targos commented Aug 2, 2018

The API was removed in v10.0.0. Adding dont-land labels for v6 and v8.

targos pushed a commit that referenced this pull request Aug 2, 2018
@maclover7 @targos
doc: mark DEP0004 and DEP0042 as End-of-Life
abac0c5 
`CryptoStream` was removed via 9301b8a.

PR-URL: #22033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 16, 2022
Open
This was referenced May 16, 2022
Open
Open
@kissofire kissofire mentioned this pull request May 16, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request May 16, 2022
Open
@ron-a20 ron-a20 mentioned this pull request May 16, 2022
Open
@molllyn1 molllyn1 mentioned this pull request May 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@maclover7 @nodejs-github-bot @targos @jasnell @addaleax @cjihrig @trivikr