Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix incorrect file mode check #22023

Closed
wants to merge 1 commit into from
Closed

test: fix incorrect file mode check #22023

wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Member

mode & fs.constants.S_IROTH !== 0 is in fact equivalent to mode & (fs.constants.S_IROTH !== 0).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@TimothyGu build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/378/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 30, 2018
devsnek
devsnek approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, binop precedence always gets me

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 30, 2018
@BridgeAR
Copy link
Member

Please +1 for fast tracking.

@TimothyGu
Copy link
Member Author

TimothyGu commented Jul 31, 2018 •
edited

Removing fast-tracking… forgot to run CI (oops!)

CI: https://ci.nodejs.org/job/node-test-pull-request/16103/

@TimothyGu TimothyGu removed the fast-track PRs that do not need to wait for 48 hours to land. label Jul 31, 2018
@trivikr
Copy link
Member

trivikr commented Aug 3, 2018

Landed in fdbc668

@trivikr trivikr closed this Aug 3, 2018
trivikr pushed a commit that referenced this pull request Aug 3, 2018
@TimothyGu @trivikr
test: fix incorrect file mode check
fdbc668 
PR-URL: #22023
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Aug 4, 2018
@TimothyGu @targos
test: fix incorrect file mode check
6cff57e 
PR-URL: #22023
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@TimothyGu TimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 7, 2018
@TimothyGu TimothyGu deleted the file-mode-check branch August 7, 2018 22:51
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@JungMinu JungMinu JungMinu approved these changes

@devsnek devsnek devsnek approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@TimothyGu @nodejs-github-bot @BridgeAR @trivikr @jasnell @lpinca @targos @cjihrig @JungMinu @devsnek