Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove test/gc, integrate into parallel #22001

Closed
wants to merge 2 commits into from
Closed

test: remove test/gc, integrate into parallel #22001

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

There’s no reason to have a separate addon just for
testing GC anymore.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

/cc @nodejs/build-files @nodejs/testing

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Jul 27, 2018
@addaleax
test: remove test/gc, integrate into parallel
a8f0307 
There’s no reason to have a separate addon just for
testing GC anymore.
@addaleax
Copy link
Member Author

addaleax commented Jul 27, 2018 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/16027/ (edit: ✔️)

@addaleax addaleax added test Issues and PRs related to the tests. and removed windows Issues and PRs related to the Windows platform. labels Jul 27, 2018
refack
refack approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺
Removing obsolete code is my favorite kind of change

@maclover7
Copy link
Contributor

Can you remove the gc entry from IGNORED_SUITES and the test directories docs

@addaleax
Copy link
Member Author

@maclover7 Done :)

@maclover7
Copy link
Contributor

Full CI: https://ci.nodejs.org/job/node-test-pull-request/16064/

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 29, 2018
@addaleax
Copy link
Member Author

Rebuild CI: https://ci.nodejs.org/job/node-test-pull-request/16094/

@addaleax
Copy link
Member Author

addaleax commented Aug 1, 2018

Landed in 02badc4

@addaleax addaleax closed this Aug 1, 2018
addaleax added a commit that referenced this pull request Aug 1, 2018
@addaleax
test: remove test/gc, integrate into parallel
02badc4 
There’s no reason to have a separate addon just for
testing GC anymore.

PR-URL: #22001
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@addaleax addaleax deleted the no-gc-tests branch August 1, 2018 16:10
targos pushed a commit that referenced this pull request Aug 1, 2018
@addaleax @targos
test: remove test/gc, integrate into parallel
0beffc0 
There’s no reason to have a separate addon just for
testing GC anymore.

PR-URL: #22001
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
@beevelop beevelop mentioned this pull request Aug 16, 2018
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@maclover7 maclover7 maclover7 approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@addaleax @nodejs-github-bot @maclover7 @refack @jasnell @benjamingr @cjihrig @richardlau @BridgeAR @trivikr