inspector: fixed V8InspectorClient::currentTimeMS method #21917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On inspector side inside V8 we assume that this method should return number of ms since epoch.
targos
approved these changes
Jul 21, 2018
devsnek
approved these changes
Jul 21, 2018
cjihrig
approved these changes
Jul 21, 2018
addaleax
approved these changes
Jul 21, 2018
TimothyGu
approved these changes
Jul 21, 2018
maclover7
added
inspector
alexkozy
added a commit
that referenced
this pull request
Aug 2, 2018
On inspector side inside V8 we assume that this method should return number of ms since epoch. PR-URL: #21917 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
|
Landed in 0ed164e |
targos
pushed a commit
that referenced
this pull request
Aug 2, 2018
On inspector side inside V8 we assume that this method should return number of ms since epoch. PR-URL: #21917 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On inspector side inside V8 we assume that this method should
return number of ms since epoch. It is important for different inspector parts,
e.g. timestamp of reported console messages.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes