deps: update V8 to 6.8 #21079

targos · 2018-06-01T09:05:20Z

ETA: July 24th

/cc @nodejs/v8-update @nodejs/tsc

targos · 2018-06-01T09:08:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/15208/
V8 CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1396/

targos · 2018-06-01T10:03:52Z

/cc @jBarz There is a failing V8 test on s390x: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1396/nodes=rhel72-s390x,v8test=v8test/testReport/junit/(root)/v8tests/mjsunit_regress_wasm_regress_827806/

mmarchini · 2018-06-01T10:42:26Z

Just an FYI (not a blocker): llnode is not ready for V8 6.8 yet, but I believe we'll finish the changes needed before June 24th.

PR if anyone is interested: nodejs/llnode#201

psmarshall · 2018-06-01T10:49:03Z

We will need the V8 ABI compat patch to make the ABI look like 6.7 - I'll work on that in about 2 weeks and link it here.

targos · 2018-06-01T11:35:50Z

macOS issue is a compiler issue. It is fixed in versions 10.11 and 10.12: https://ci.nodejs.org/job/node-test-commit-osx-targos/3/

@mhdawson

ofrobots · 2018-06-01T21:07:08Z

@psmarshall The V8 6.7 compat patch is not needed for this to land on master, but it would still be good to have it sooner rather than later.

mhdawson · 2018-06-05T22:31:52Z

We'll need to adjust the OSX machines for testing/release @gdams can you help to get an OSX 10.11 machine setup for release? @rvagg we should also schedule a talk with @gdams about OSX and mac stadium.

targos · 2018-06-10T09:31:49Z

src/node_platform.cc

-static void BackgroundRunner(void* data) {
+namespace {
+
+static void WorkerThreadMain(void* data) {
  TRACE_EVENT_METADATA1("__metadata", "thread_name", "name",
                        "BackgroundTaskRunner");


Do we have to change this? @nodejs/trace-events

It makes sense to change this to match the concept name actually used by V8, that is, 'WorkerThread'. However, things going to get really confusing since we also have worker_threads from #20876.

One of these concepts needs to be renamed for sanity's sake. /cc @addaleax

One option would be to use something like 'PlatformWorkerThread' here.

hashseed · 2018-06-10T13:33:38Z

@psmarshall The V8 6.7 compat patch is not needed for this to land on master, but it would still be good to have it sooner rather than later.

Peter will work on this next week.

refack · 2018-06-10T15:08:07Z

macOS issue is a compiler issue. It is fixed in versions 10.11 and 10.12: ci.nodejs.org/job/node-test-commit-osx-targos/3

Googling and digging brought up this: https://stackoverflow.com/questions/23791060/c-thread-local-storage-clang-503-0-40-mac-osx

Might be helpful if someone from Apple would comment if simply updating xcode will solve this (cough @gibfahn cough)

mhdawson · 2018-06-19T18:57:01Z

Issue for OSX in build repo: nodejs/build#1358

jasnell

rubber stamp LGTM

targos · 2018-07-04T19:44:28Z

Just updated to check where we are.
CI: https://ci.nodejs.org/job/node-test-pull-request/15729/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1509/

targos · 2018-07-19T09:35:07Z

New check

CI: https://ci.nodejs.org/job/node-test-pull-request/15945/
Edit: resumed build: https://ci.nodejs.org/job/node-test-pull-request/15948/

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1529/

Backport-PR-URL: #21668 PR-URL: #21079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org>

Synchronize source files list with upstream's BUILD.gn. Teach v8.gyp to build and run torque, V8's DSL for generating builtins. On Windows, the torque binary needs to be compiled and linked with exception semantics and assume V8 is embedded. Fixes: nodejs/node-v8#57 Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl> Co-Authored-By: Refael Ackermann <refack@gmail.com> Backport-PR-URL: #21668 PR-URL: #21079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org>

Original commit message: [log][api] introduce public CodeEventListener API Introduce a new public API called CodeEventListener to allow embedders to better support external profilers and other diagnostic tools without relying on unsupported methods like --perf-basic-prof. Bug: v8:7694 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I063cc965394d59401358757634c9ea84c11517e9 Co-authored-by: Daniel Beckert <daniel@sthima.com.br> Reviewed-on: https://chromium-review.googlesource.com/1028770 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53382} Refs: v8/v8@aa6ce3e Backport-PR-URL: #21668 PR-URL: #21079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org>

As per Node.js docs, vm.Script instance is not bound to any context. However, this test was expecting otherwise and depended on implementation details which are going to change. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1013581 Backport-PR-URL: #21668 PR-URL: #21079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org>

This commit updates the following postmortem metadata constant: - v8dbg_context_idx_closure - Renamed: v8dbg_context_idx_scope_info - V8 commit: v8/v8@39496a9#diff-f3f182b0510ba2ee39ae87e421ff110b Fixes: nodejs/node-v8#59 Backport-PR-URL: #21668 PR-URL: #21079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org>

Notable changes: * deps: Upgrade V8 from 6.7 to 6.8 (Michaël Zasso) #21079 * Memory reduction and performance improvements, details at: https://v8project.blogspot.com/2018/06/v8-release-68.html * fs: Implement a fs.mkdir() recursive option, similar to the mkdirp npm package or mkdir -p on the command line (Benjamin Coe) #21875 * http: http.get() and http.request() (and https variants) can now accept three arguments to allow for a URL and an options object (Sam Ruby) #21616

Notable changes: * deps: Upgrade V8 from 6.7 to 6.8 (Michaël Zasso) #21079 * Memory reduction and performance improvements, details at: https://v8project.blogspot.com/2018/06/v8-release-68.html * fs: Implement a fs.mkdir() recursive option, similar to the mkdirp npm package or mkdir -p on the command line (Benjamin Coe) #21875 * http: http.get() and http.request() (and https variants) can now accept three arguments to allow for a URL and an options object (Sam Ruby) #21616 * Added new collaborators * Sam Ruby (https://github.com/rubys) * George Adams (https://github.com/gdams)

Notable changes: * buffer: * Fix out-of-bounds (OOB) write in `Buffer.write()` for UCS-2 encoding (CVE-2018-12115) * Fix unintentional exposure of uninitialized memory in `Buffer.alloc()` (CVE-2018-7166) * deps: * Upgrade to OpenSSL 1.1.0i, fixing: - Client DoS due to large DH parameter (CVE-2018-0732) - ECDSA key extraction via local side-channel (CVE not assigned) * Upgrade V8 from 6.7 to 6.8 (Michaël Zasso) #21079 - Memory reduction and performance improvements, details at: https://v8project.blogspot.com/2018/06/v8-release-68.html * http: `http.get()` and `http.request()` (and `https` variants) can now accept three arguments to allow for a `URL` _and_ an `options` object (Sam Ruby) #21616 * Added new collaborators * Sam Ruby (https://github.com/rubys) * George Adams (https://github.com/gdams)

Precursor to removing deprecated APIs on the v8 side @ https://chromium-review.googlesource.com/c/v8/v8/+/1045310 PR-URL: nodejs/node#21079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> (cherry-picked from 0f3c2c6)

Precursor to removing deprecated APIs on the v8 side @ https://chromium-review.googlesource.com/c/v8/v8/+/1045310 PR-URL: nodejs#21079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org>

Refs: nodejs#21079 (comment) PR-URL: nodejs#21982 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. blocked PRs that are blocked by other issues or PRs. labels Jun 1, 2018

targos requested a review from a team as a code owner June 1, 2018 09:05

nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Jun 1, 2018

targos removed the build Issues and PRs related to build files or the CI. label Jun 1, 2018

targos mentioned this pull request Jun 4, 2018

macOS build failure nodejs/node-v8#63

Closed

targos force-pushed the v8-6.8 branch from 0bd0bd8 to 1184097 Compare June 10, 2018 09:28

targos commented Jun 10, 2018

View reviewed changes

targos mentioned this pull request Jun 18, 2018

ansible: install multiple versions of xcode on build machines nodejs/build#1358

Closed

targos force-pushed the v8-6.8 branch from 1184097 to 4daface Compare June 20, 2018 19:54

jasnell approved these changes Jun 21, 2018

View reviewed changes

targos force-pushed the v8-6.8 branch from 4daface to 0066ae7 Compare July 4, 2018 19:43

targos force-pushed the v8-6.8 branch from 0066ae7 to 657f859 Compare July 5, 2018 07:07

psmarshall mentioned this pull request Jul 5, 2018

[v10.x] deps: update V8 to 6.8 #21668

Closed

2 tasks

targos force-pushed the v8-6.8 branch 2 times, most recently from 4870e7a to 7ab3258 Compare July 19, 2018 09:33

targos added backported-to-v10.x and removed backport-requested-v10.x labels Aug 11, 2018

rvagg mentioned this pull request Aug 13, 2018

Release proposal: v10.9.0 #22295

Merged

targos added this to Backported in v10.x Sep 23, 2018

Cogitri mentioned this pull request Jan 4, 2019

nxodejs: fix cross void-linux/void-packages#6573

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 6.8 #21079

deps: update V8 to 6.8 #21079

targos commented Jun 1, 2018

targos commented Jun 1, 2018

targos commented Jun 1, 2018

mmarchini commented Jun 1, 2018

psmarshall commented Jun 1, 2018

targos commented Jun 1, 2018

ofrobots commented Jun 1, 2018

mhdawson commented Jun 5, 2018

targos Jun 10, 2018

ofrobots Jun 10, 2018

ofrobots Jun 10, 2018

hashseed commented Jun 10, 2018

refack commented Jun 10, 2018

mhdawson commented Jun 19, 2018

jasnell left a comment

targos commented Jul 4, 2018

targos commented Jul 19, 2018 •

edited

deps: update V8 to 6.8 #21079

deps: update V8 to 6.8 #21079

Conversation

targos commented Jun 1, 2018

targos commented Jun 1, 2018

targos commented Jun 1, 2018

mmarchini commented Jun 1, 2018

psmarshall commented Jun 1, 2018

targos commented Jun 1, 2018

ofrobots commented Jun 1, 2018

mhdawson commented Jun 5, 2018

targos Jun 10, 2018

Choose a reason for hiding this comment

ofrobots Jun 10, 2018

Choose a reason for hiding this comment

ofrobots Jun 10, 2018

Choose a reason for hiding this comment

hashseed commented Jun 10, 2018

refack commented Jun 10, 2018

mhdawson commented Jun 19, 2018

jasnell left a comment

Choose a reason for hiding this comment

targos commented Jul 4, 2018

targos commented Jul 19, 2018 • edited

targos commented Jul 19, 2018 •

edited