fix: filtering by regex

[hisabimbola]

Add failing tests for #1080

[gr2m]

Thanks for the PR! I assume you are working on figuring it out a fix?

[hisabimbola]

Hey @gr2m

I think this should look good now. I also added test, please review.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

[RichardLitt]

@hisabimbola It looks like we haven't reviewed this again. I'm reopening it.

[RichardLitt]

@gr2m I think this is ready; what do you think?

[hisabimbola]

Let me know if any changes are needed aside resolving the conflict

[RichardLitt]

This looks fine to me! @gr2m Any time to check this again?

[gr2m]

yep looks good, just need rebasing :) Could you do that @hisabimbola?

[hisabimbola]

yeah @gr2m updated the PR

[gr2m]

Thanks Abimbola!

[nockbot]

🎉 This PR is included in version 10.0.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!