Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

5.3.1 has breaking change #574

Closed
tylerlong opened this issue Oct 16, 2018 · 4 comments
Closed

5.3.1 has breaking change #574

tylerlong opened this issue Oct 16, 2018 · 4 comments

Comments

@tylerlong
Copy link

index.min.js:1 Uncaught ReferenceError: process is not defined
    at index.min.js:1
    at i (index.min.js:1)
    at index.min.js:1
    at index.min.js:1
    at index.min.js:1

I am using CDN version: https://unpkg.com/mobx-react@5.3.1/index.min.js

5.2.8 version is fine.

@xaviergonz
Copy link
Contributor

that's weird, the actual piece of code that fails comes from react itself... it seems like react is not being applied properly as an external by rollup

@xaviergonz
Copy link
Contributor

ok, false alarm (kind of), it comes from react-is, which is a dependency of hoist-non-react-statics

@mweststrate should mobx react do something like
if (typeof "process" === "undefined") { process = { env: {} } }

on index.js before all imports?

@xaviergonz
Copy link
Contributor

nevermind, using rollup-plugin-replace is a better option, PR for it ready

@mweststrate
Copy link
Member

Released as 5.3.2

@github-actions github-actions bot mentioned this issue Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants