Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(add): Validate local package version #1804

Merged
merged 1 commit into from Dec 6, 2018
Merged

fix(add): Validate local package version #1804

merged 1 commit into from Dec 6, 2018

Conversation

tanhauhau
Copy link
Contributor

Fix #1799

Description

Motivation and Context

How Has This Been Tested?

Added test to show error thrown when installing a local package without version specified

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

evocateur
evocateur approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@evocateur evocateur merged commit ed6e2db into lerna:master Dec 6, 2018
@evocateur evocateur mentioned this pull request Dec 6, 2018
Closed
9 tasks
@tanhauhau tanhauhau deleted the tanhauhau/lerna-add-validation branch December 8, 2018 03:59
This was referenced Dec 8, 2018
Closed
Closed
Merged
Merged
@lock
Copy link

lock bot commented Feb 6, 2019

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evocateur evocateur evocateur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'lerna add' creates dependency on '^undefined' tag if package.json is missing version
2 participants
@tanhauhau @evocateur