fix(add): Validate local package version (#1804)

Fixes #1799

commands/add/__tests__/__fixtures__/unspecified-version/lerna.json

@@ -0,0 +1,3 @@
+{
+  "version": "1.0.0"
+}

commands/add/__tests__/__fixtures__/unspecified-version/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "unspecified-version",
+  "version": "monorepo",
+  "private": true,
+  "dependencies": {
+    "bar": "^2.0.0"
+  }
+}

commands/add/__tests__/__fixtures__/unspecified-version/packages/package-1/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "@test/package-1"
+}

commands/add/__tests__/__fixtures__/unspecified-version/packages/package-2/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "@test/package-2",
+  "version": "2.0.0"
+}

commands/add/__tests__/add-command.test.js

@@ -49,6 +49,18 @@ describe("AddCommand", () => {
     }
   });
 
+  it("should throw for adding local package without specified version", async () => {
+    expect.assertions(1);
+
+    const testDir = await initFixture("unspecified-version");
+
+    try {
+      await lernaAdd(testDir)("@test/package-1");
+    } catch (err) {
+      expect(err.message).toMatch(/Requested package has no version:/);
+    }
+  });
+
   it("should reference remote dependencies", async () => {
     const testDir = await initFixture("basic");
 

commands/add/index.js

@@ -50,6 +50,14 @@ class AddCommand extends Command {
 
     chain = chain.then(() => this.getPackageVersion());
     chain = chain.then(version => {
+      if (version == null) {
+        throw new ValidationError(
+          "ENOTSATISFIED",
+          dedent`
+            Requested package has no version: ${this.spec.name}
+          `
+        );
+      }
       this.spec.version = version;
     });