fix: Upgrade init'ed and allowed versions of TypeScript (closes #203) #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 12 12
Lines 814 814
Branches 65 65
=======================================
Hits 802 802
Misses 12 12
Continue to review full report at Codecov.
|
Closed
carnesen
commented
Sep 22, 2018
| const deps: Bag<string> = {'gts': `^${pkg.version}`, 'typescript': '~2.8.0'}; | ||
| const deps: Bag<string> = { | ||
| gts: `^${pkg.version}`, | ||
| typescript: pkg.devDependencies.typescript |
There was a problem hiding this comment.
Currently the value of pkg.devDependencies.typescript is ~3.0.0
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this PR is merged
gtswill allow TypeScript 3.x as a peer dependencygts initwill installtypescript@~3.0.0gts init-installed version of typescript will be derived from this package's devDependencies.