When a root expires, flush all expired work in a single batch #13503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 🔺+0.2%, gzip: 🔺+0.1% Details of bundled changes.Comparing: bb62722...077addd react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
schedule
Generated by 🚫 dangerJS |
|
It looks like it's helping. Still gets stuck sometimes but I suppose it's just two expirations happening one after the other (because the commit itself took a long time). But nothing like it was getting stuck before. |
mihalskiy
approved these changes
Aug 28, 2018
acdlite
force-pushed
the
batchexpiredupdates
branch
2 times, most recently
from
f28c369
to
801a2d8
Compare
|
@gaearon Ready for review |
acdlite
force-pushed
the
batchexpiredupdates
branch
3 times, most recently
from
7f19945
to
0d9802f
Compare
Instead of flushing each level one at a time.
acdlite
force-pushed
the
batchexpiredupdates
branch
from
0d9802f
to
077addd
Compare
Merged
gaearon
approved these changes
Sep 5, 2018
There was a problem hiding this comment.
This makes sense to me by itself but doesn't actually help the issue reproducible in the fixture. If you try to type a lot and then constantly add and remove characters it will eventually expire with isExpired = false. However the scheduler thinks there's still some time before the timeout, so didTimeout is false. I'm not sure why but we need to fix this too?
|
Let's get this fix in, but we'll need a follow-up for scheduler itself. |
This was referenced Sep 7, 2018
This was referenced Nov 1, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…ok#13503) Instead of flushing each level one at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add some Suspense tests, and some comments. Pushing so Dan can test if it fixes the issue in the fixture.