Provide component reference in ReactDOMFiberTextarea warnings #13361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunofreiberg
changed the title
gaearon
requested changes
Aug 10, 2018
| @@ -70,11 +71,13 @@ export function initWrapperState(element: Element, props: Object) { | |||
| ) { | |||
| warning( | |||
| false, | |||
| 'Textarea elements must be either controlled or uncontrolled ' + | |||
| '%s contains an textarea with both value and defaultValue props. ' + | |||
| @@ -404,7 +404,8 @@ describe('ReactDOMTextarea', () => { | |||
| <textarea value="foo" defaultValue="bar" readOnly={true} />, | |||
| ), | |||
| ).toWarnDev( | |||
| 'Textarea elements must be either controlled or uncontrolled ' + | |||
| 'A component contains an textarea with both value and defaultValue props. ' + | |||
There was a problem hiding this comment.
Let’s change the test to have an owner?
|
✅ |
gaearon
approved these changes
Aug 13, 2018
|
Thanks |
Merged
This was referenced Sep 7, 2018
This was referenced Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
ReactDOMFiberInput.jsprovides a reference to the component, if possible. Why not do the same forReactDOMFiberTextarea.jsas well :-)?