Enhance get derived state from props state warning - #12670 #13317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I ended up tweaking the message since people are often confused why we have it. |
gaearon
force-pushed
the
bugfix/enhance-getDerivedStateFromProps-state-warning
branch
from
39f9b26
to
0b54ed3
Compare
|
yeah, right 👍 @gaearon although I don't get why you would intentionally set state to null 😅 |
Merged
This was referenced Sep 7, 2018
This was referenced Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current warning that
getDerivedStateFromPropsproduces when called withstate == null(intentional null or undefined/not declared) is a bit unclear, so this PR adapts this message for the developer to directly recognize that he didn't declare the Component's state beforegetDerivedStateFromProps.Resolves: #12670.
The updated message is now: