feat: Adds style injection for modules in functional components. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyerburgh
reviewed
May 18, 2018
| @@ -0,0 +1,25 @@ | |||
| <template> | |||
There was a problem hiding this comment.
This isn't a functional component
There was a problem hiding this comment.
Good catch! Sorry for that. Should be fixed in 4ecb707.
jeremyzahner
force-pushed
the
scss-injection-functional
branch
from
c671755
to
4ecb707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix vue-jest's behavior concerning style injection with modules on functional components.
Edit: We've added this branch to a current project and tested it's fixes together with a lot of functional components.