Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trailingComments for FunctionExpression that is CallExpression arguments #8488

Merged
merged 2 commits into from Aug 21, 2018
Merged

Fix trailingComments for FunctionExpression that is CallExpression arguments #8488

merged 2 commits into from Aug 21, 2018

Conversation

jiaxuan
Copy link
Contributor

@jiaxuan jiaxuan commented Aug 18, 2018

Q                       A
Fixed Issues? Fixes #8483
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes?
License MIT

I'd very much prefer Array.filter to for loop. I left it there to be consistent with the case for ObjectProperty before this.

@babel-bot
Copy link
Collaborator

babel-bot commented Aug 18, 2018 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8868/

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser area: comments labels Aug 19, 2018
@existentialism
Copy link
Member

Can we add a test?

existentialism
existentialism approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a test, will land after CI!

@existentialism existentialism merged commit b439013 into babel:master Aug 21, 2018
@existentialism
Copy link
Member

@jiaxuan thanks for the PR!

@banga banga mentioned this pull request Aug 26, 2019
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: comments outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrectly attributed trailingComments for CallExpression
4 participants
@jiaxuan @babel-bot @existentialism @nicolo-ribaudo