Fixes setter paratemer default value #8479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8824/ |
hzoo
approved these changes
Aug 15, 2018
| @@ -60,7 +60,8 @@ export default function convertFunctionParams(path, loose) { | |||
| for (let i = 0; i < params.length; i++) { | |||
| const param = params[i]; | |||
|
|
|||
| if (param.isAssignmentPattern() && loose) { | |||
| const paramIsAssignmentPattern = param.isAssignmentPattern(); | |||
| if (paramIsAssignmentPattern && loose) { | |||
There was a problem hiding this comment.
Instead of setting loose to true for setters, could you update this check to (loose || node.kind === "set")?
It would be a little more descriptive and, if we use loose for other parts of the transform on the future, they won't be automatically enabled for setters since they might not be needed.
There was a problem hiding this comment.
In the beginning i did so. But later..
existentialism
added
the
PR: Bug Fix 🐛
existentialism
approved these changes
Aug 16, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces setter's default parameter to use loose transform