Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/TypeScript
base: v2.8.3
Choose a base ref
...
head repository: microsoft/TypeScript
compare: v2.8.4
Choose a head ref
  • 10 commits
  • 15 files changed
  • 4 contributors

Commits on May 11, 2018

  1. Port fix #24050 from master to release-2.8 

    Fixes #24015
    @RyanCavanaugh
    RyanCavanaugh committed May 11, 2018
    Configuration menu
    Copy the full SHA
    e03e2ae View commit details
    Browse the repository at this point in the history

  2. Merge pull request #24052 from RyanCavanaugh/portInitializerFix 

    Port fix #24050 from master to release-2.8
    @billti
    billti committed May 11, 2018
    Configuration menu
    Copy the full SHA
    92b18d8 View commit details
    Browse the repository at this point in the history

  3. Bump version to 2.8.4

    @billti
    billti committed May 11, 2018
    Configuration menu
    Copy the full SHA
    850cfc5 View commit details
    Browse the repository at this point in the history

  4. Update LKG

    @billti
    billti committed May 11, 2018
    Configuration menu
    Copy the full SHA
    22715da View commit details
    Browse the repository at this point in the history

  5. Merge pull request #24053 from Microsoft/dev/billti/update-to-2.8.4 

    Update to 2.8.4 and bump LKG
    @billti
    billti committed May 11, 2018
    Configuration menu
    Copy the full SHA
    6b21c37 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2018

  1. JS initializers use original valueDecl, not mutated 

    target's valueDeclaration is set to the source's if it is not present.
This makes it incorrect to use getJSInitializerSymbol because it relies
on the symbol's valueDeclaration.

This fix just saves the original valueDeclaration before mutating and
uses that.
    @sandersn
    sandersn committed May 15, 2018
    Configuration menu
    Copy the full SHA
    68875dc View commit details
    Browse the repository at this point in the history

  2. Compare merged targetInitializer to target 

    Instead of the unmerged one
    @sandersn
    sandersn committed May 15, 2018
    Configuration menu
    Copy the full SHA
    c798e21 View commit details
    Browse the repository at this point in the history

  3. Add test of stack overflow

    @sandersn
    sandersn committed May 15, 2018
    Configuration menu
    Copy the full SHA
    2d7efb3 View commit details
    Browse the repository at this point in the history

  4. Accept new baselines 

    Baselines print worse because 2.8 is missing improvements in type
printing and symbol structure.
    @sandersn
    sandersn committed May 15, 2018
    Configuration menu
    Copy the full SHA
    acd7f81 View commit details
    Browse the repository at this point in the history

  5. Update LKG

    @mhegazy
    mhegazy committed May 15, 2018
    Configuration menu
    Copy the full SHA
    c59ea30 View commit details
    Browse the repository at this point in the history